dtc/develop: update logic around builddir (ccpp_prebuild.py) / basedir (metadata2html.py) #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd basedir/builddir argument, use default value from CCPP prebuild config if not provided on the command line (ccpp_prebuild.py), always use default value from CCPP prebuild config (metadata2html.py)
climbfuji
changed the title
This was referenced Nov 26, 2019
|
Associated PRs: NCAR/ufs-weather-model#8 For regression testing, see NCAR/ufs-weather-model#8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the logic around the current command line arguments
--builddir(forccpp_prebuild.py) and--basedir(formetadata2html.py).ccpp_prebuild.py: use default value from the CCPP prebuild config (newly added) if not provided on the command line; this means that the default build is in-source, but by specifying--builddiran out-of-source build can be requested; this is also backward compatible with the current settings in UFS and SCMmetadata2html.py: since it does not make sense to create the html tables from the CCPP metadata outside of the source directories (all accompanying doxygen files are in-source), always use the default value from the CCPP prebuild config, remove the command line argument entirelyWith this change, it is possible to run
metadata2html.pyfrom the top-levelufs-weather-modeldirectory as follows (for bulk conversions):